linux-kernel - Re: [PATCH] usb: typec: mux: do not return on EOPNOTSUPP in {mux, switch}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_PKgnPDpWPrrEK3@kuha.fi.intel.com>
Date: Mon, 7 Apr 2025 15:52:18 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] usb: typec: mux: do not return on EOPNOTSUPP in {mux,
 switch}_set

On Fri, Apr 04, 2025 at 12:21:01AM +0200, Michael Grzeschik wrote:
> Since the typec connectors can have many muxes or switches for different
> lanes (sbu, usb2, usb3) going into different modal states (usb2, usb3,
> audio, debug) all of them will be called on typec_switch_set and
> typec_mux_set. But not all of them will be handling the expected mode.
> 
> If one of the mux or switch will come back with EOPTNOSUPP this is no
> reason to stop running through the next ones. Therefor we skip this
> particular error value and continue calling the next.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
> index 49926d6e72c71..182c902c42f61 100644
> --- a/drivers/usb/typec/mux.c
> +++ b/drivers/usb/typec/mux.c
> @@ -214,7 +214,7 @@ int typec_switch_set(struct typec_switch *sw,
>  		sw_dev = sw->sw_devs[i];
>  
>  		ret = sw_dev->set(sw_dev, orientation);
> -		if (ret)
> +		if (ret && ret != -EOPNOTSUPP)
>  			return ret;
>  	}
>  
> @@ -378,7 +378,7 @@ int typec_mux_set(struct typec_mux *mux, struct typec_mux_state *state)
>  		mux_dev = mux->mux_devs[i];
>  
>  		ret = mux_dev->set(mux_dev, state);
> -		if (ret)
> +		if (ret && ret != -EOPNOTSUPP)
>  			return ret;
>  	}

thanks,

-- 
heikki