linux-kernel - Re: [PATCH 1/2] ethtool: transceiver reset and presence pin control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407153203.0a3037d7@kmaincent-XPS-13-7390>
Date: Mon, 7 Apr 2025 15:32:03 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Marek Pazdan <mpazdan@...sta.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Willem de
 Bruijn <willemb@...gle.com>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Mina Almasry <almasrymina@...gle.com>,
 Edward Cree <ecree.xilinx@...il.com>, Daniel Zahka
 <daniel.zahka@...il.com>, Jianbo Liu <jianbol@...dia.com>, Gal Pressman
 <gal@...dia.com>
Subject: Re: [PATCH 1/2] ethtool: transceiver reset and presence pin control

On Mon,  7 Apr 2025 12:35:37 +0000
Marek Pazdan <mpazdan@...sta.com> wrote:

> Signal Definition section (Other signals) of SFF-8636 Spec mentions that
> additional signals like reset and module present may be implemented for
> a specific hardware. There is currently no user space API for control of
> those signals so user space management applications have no chance to
> perform some diagnostic or configuration operations. This patch uses
> get_phy_tunable/set_phy_tunable ioctl API to provide above control to
> user space. Despite ethtool reset option seems to be more suitable for
> transceiver module reset control, ethtool reset doesn't allow for reset
> pin assertion and deassertion. Userspace API may require control over
> when pin will be asserte and deasserted so we cannot trigger reset and
> leave it to the driver when deassert should be perfromed.

nit: performed

ETHTOOL_PHY_G/STUNABLE IOCTLs are targeting the PHY of the NIC but IIUC in your
case you are targeting the reset of the QSFP module. Maybe phylink API is more
appropriate for this feature.

You have to add net-next prefix in the subject like this [PATCH net-next 1/2]
when you add new support to net subsystem.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com