linux-kernel - Re: [PATCH 2/2] ice: add qsfp transceiver reset and presence pin control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407154613.00e7afe2@kmaincent-XPS-13-7390>
Date: Mon, 7 Apr 2025 15:46:13 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Marek Pazdan <mpazdan@...sta.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Willem de
 Bruijn <willemb@...gle.com>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Mina Almasry <almasrymina@...gle.com>,
 Edward Cree <ecree.xilinx@...il.com>, Daniel Zahka
 <daniel.zahka@...il.com>, Jianbo Liu <jianbol@...dia.com>, Gal Pressman
 <gal@...dia.com>
Subject: Re: [PATCH 2/2] ice: add qsfp transceiver reset and presence pin
 control

On Mon,  7 Apr 2025 12:35:38 +0000
Marek Pazdan <mpazdan@...sta.com> wrote:

> Commit f3c1c896f5a8 ("ethtool: transceiver reset and presence pin control")
> adds ioctl API extension for get/set-phy-tunable so that transceiver
> reset and presence pin control is enabled.

I don't think pointing and explaining the first commit is relevant here.

> This commit adds functionality to utilize the API in ice driver.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

You could simply write:
Add support for the newly introduced transceiver reset feature in the ice
driver.

> According to E810 datasheet QSFP reset and presence pins are being
> connected to SDP0 and SDP2 pins on controller host. Those pins can
> be accessed using AQ commands for GPIO get/set.[O

Weird character at the end.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com