linux-kernel - Re: [PATCH] staging: gpib: fmh_gpib: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtywgRJRN9ANtEiSyfy176u-CVBbWl66cyJYux27ismpRife21AZPaAymJnsAcjW06V_J_Rl6RBuqm40yOvobfnz37QmZ3XaeFNCDsKhNSQ=@protonmail.com>
Date: Mon, 07 Apr 2025 13:39:00 +0000
From: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: dpenkler@...il.com, gregkh@...uxfoundation.org, matchstick@...erthere.org, arnd@...db.de, nathan@...nel.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: fmh_gpib: Remove unnecessary print function dev_err()

On Monday, April 7th, 2025 at 05:11, Chen Ni <nichen@...as.ac.cn> wrote:

> 
> 
> Function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Signed-off-by: Chen Ni nichen@...as.ac.cn
> 
> ---
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> index 53f4b3fccc3c..5f64f3d989ef 100644
> --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> @@ -1424,10 +1424,8 @@ static int fmh_gpib_attach_impl(struct gpib_board *board, const gpib_board_confi
> (unsigned long)resource_size(e_priv->dma_port_res));
> 
> 
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(board->dev, "request for IRQ failed\n");
> 
> + if (irq < 0)
> return -EBUSY;
> - }
> retval = request_irq(irq, fmh_gpib_interrupt, IRQF_SHARED, pdev->name, board);
> 
> if (retval) {
> dev_err(board->dev,
> 
> --
> 2.25.1

LGTM,
Reviewed-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>