[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z_PVfqVzvscBFND_@blossom>
Date: Mon, 7 Apr 2025 09:39:10 -0400
From: Alyssa Rosenzweig <alyssa@...enzweig.io>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Petr Mladek <pmladek@...e.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Sven Peter <sven@...npeter.dev>,
Thomas Zimmermann <tzimmermann@...e.de>,
Aun-Ali Zaidi <admin@...eit.net>,
Maxime Ripard <mripard@...nel.org>, airlied@...hat.com,
Simona Vetter <simona@...ll.ch>,
Steven Rostedt <rostedt@...dmis.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Jonathan Corbet <corbet@....net>,
Andrew Morton <akpm@...ux-foundation.org>, apw@...onical.com,
joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
Kees Cook <kees@...nel.org>, tamird@...il.com,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
Hector Martin <marcan@...can.st>,
Asahi Linux Mailing List <asahi@...ts.linux.dev>
Subject: Re: [PATCH v3 3/3] drm/appletbdrm: use %p4cl instead of %p4cc
Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
Le Mon , Apr 07, 2025 at 07:07:54PM +0530, Aditya Garg a écrit :
> From: Aditya Garg <gargaditya08@...e.com>
>
> Due to lack of a proper printk format, %p4cc was being used instead of
> %p4cl for the purpose of printing FourCCs. But the disadvange was that
> they were being printed in a reverse order. %p4cl should correct this
> issue.
>
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> ---
> drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
> index 703b9a41a..751b05753 100644
> --- a/drivers/gpu/drm/tiny/appletbdrm.c
> +++ b/drivers/gpu/drm/tiny/appletbdrm.c
> @@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev,
> }
>
> if (response->msg != expected_response) {
> - drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n",
> + drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n",
> &expected_response, &response->msg);
> return -EIO;
> }
> @@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev)
> }
>
> if (pixel_format != APPLETBDRM_PIXEL_FORMAT) {
> - drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format);
> + drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format);
> ret = -EINVAL;
> goto free_info;
> }
> --
> 2.43.0
>
Powered by blists - more mailing lists