linux-kernel - Re: [PATCH v2 2/2] vsprintf: remove redundant and unused %pCn format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407184647.3b72de47@booty>
Date: Mon, 7 Apr 2025 18:46:47 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Petr Mladek <pmladek@...e.com>, Daniel Lezcano
 <daniel.lezcano@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Zhang Rui
 <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, Scott Branden
 <sbranden@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Steven Rostedt
 <rostedt@...dmis.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Rasmus Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky
 <senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>, Andrew Morton
 <akpm@...ux-foundation.org>, Alex Shi <alexs@...nel.org>, Yanteng Si
 <si.yanteng@...ux.dev>, Binbin Zhou <zhoubinbin@...ngson.cn>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Geert
 Uytterhoeven <geert+renesas@...der.be>, Liu Ying <victor.liu@....com>,
 linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 2/2] vsprintf: remove redundant and unused %pCn
 format specifier

Hello Petr, Daniel,

On Tue, 11 Mar 2025 15:36:11 +0100
Petr Mladek <pmladek@...e.com> wrote:

> On Tue 2025-03-11 10:21:23, Luca Ceresoli wrote:
> > %pC and %pCn print the same string, and commit 900cca294425 ("lib/vsprintf:
> > add %pC{,n,r} format specifiers for clocks") introducing them does not
> > clarify any intended difference. It can be assumed %pC is a default for
> > %pCn as some other specifiers do, but not all are consistent with this
> > policy. Moreover there is now no other suffix other than 'n', which makes a
> > default not really useful.
> > 
> > All users in the kernel were using %pC except for one which has been
> > converted. So now remove %pCn and all the unnecessary extra code and
> > documentation.
> > 
> > Acked-by: Stephen Boyd <sboyd@...nel.org>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>  
> 
> Makes sense. Looks and works well, so:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> Tested-by: Petr Mladek <pmladek@...e.com>
> 
> Daniel, if I get it correctly, you have already taken the 1st patch.
> Would you mind to take also this patch using the same tree, please?
> Otherwise, we would need to coordinate pull requests in the upcoming
> merge window ;-)

I see none of these two patches in linux-next.

Anything I should do? Resend? Or just wait a bit more?

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com