linux-kernel - Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407101129.48048623@kernel.org>
Date: Mon, 7 Apr 2025 10:11:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <horms@...nel.org>, <shenjian15@...wei.com>,
 <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
 <chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
 <shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac
 addr after reset issue

On Mon, 7 Apr 2025 09:06:42 +0800 Jijie Shao wrote:
> on 2025/4/4 22:58, Jakub Kicinski wrote:
> > On Thu, 3 Apr 2025 21:53:10 +0800 Jijie Shao wrote:  
> >> In normal cases, the driver must ensure that the value
> >> of rx pause mac addr is the same as the MAC address of
> >> the network port. This ensures that the driver can
> >> receive pause frames whose destination address is
> >> the MAC address of the network port.  
> > I thought "in normal cases" pause frames use 01:80:C2:00:00:01
> > as the destination address!?  
> 
> No, the address set in .ndo_set_mac_address() is used.
> 01:80:C2:00:00:01 is supported by default. No additional configuration is required.

Are you talking about source or destination?
How does the sender learn the receiver's address? Via LLDP?
You need to explain all this much better in the commit message.
It is not "normal" for a switched Ethernet network.