linux-kernel - Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3aafd85-cb58-4046-88df-2b3566e2497d@huawei.com>
Date: Mon, 7 Apr 2025 09:06:42 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac
 addr after reset issue


on 2025/4/4 22:58, Jakub Kicinski wrote:
> On Thu, 3 Apr 2025 21:53:10 +0800 Jijie Shao wrote:
>> In normal cases, the driver must ensure that the value
>> of rx pause mac addr is the same as the MAC address of
>> the network port. This ensures that the driver can
>> receive pause frames whose destination address is
>> the MAC address of the network port.
> I thought "in normal cases" pause frames use 01:80:C2:00:00:01
> as the destination address!?

No, the address set in .ndo_set_mac_address() is used.
01:80:C2:00:00:01 is supported by default. No additional configuration is required.

>
> Are you sure this patch is not a misunderstanding, and the issue
> is already fixed by patch 2?

It's a different issue. This patch is used to solve the problem that
the configuration is lost after reset.

>
>> Currently, the rx pause addr does not restored after reset.

Here.

>>
>> The index of the MAC address of the host is always 0.
>> Therefore, this patch sets rx pause addr to
>> the MAC address with index 0.