linux-kernel - Re: [PATCH 18/28] dpll: zl3073x: Read optional pin properties from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09e09598-945b-4f26-a5f4-9f1a17a709c4@kernel.org>
Date: Mon, 7 Apr 2025 20:06:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
Cc: Michal Schmidt <mschmidt@...hat.com>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jiri Pirko <jiri@...nulli.us>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Lee Jones <lee@...nel.org>, Kees Cook <kees@...nel.org>,
 Andy Shevchenko <andy@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 18/28] dpll: zl3073x: Read optional pin properties from
 firmware

On 07/04/2025 19:31, Ivan Vecera wrote:
> +
> +	if (zl3073x_dpll_is_input_pin(pin))
> +		node_name = "input-pins";
> +	else
> +		node_name = "output-pins";
> +
> +	/* Get node containing input or output pins */
> +	pins_node = device_get_named_child_node(zldpll->mfd->dev, node_name);
> +	if (!pins_node) {
> +		dev_dbg(zldpll->mfd->dev, "'%s' sub-node is missing\n",
> +			node_name);
> +		return NULL;
> +	}
> +
> +	/* Get pin HW index */
> +	idx = zl3073x_dpll_pin_index_get(pin);
> +
> +	/* Enumerate pin nodes and find the requested one */
> +	fwnode_for_each_child_node(pins_node, pin_node) {
> +		u32 reg;
> +
> +		if (fwnode_property_read_u32(pin_node, "reg", &reg))
> +			continue;
> +
> +		if (idx == reg)
> +			break;

Where do you drop the reference to pin_node?

> +	}
> +
> +	/* Release pin parent node */
> +	fwnode_handle_put(pins_node);
> +



Best regards,
Krzysztof