linux-kernel - Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250407182341.GA1771020@nvidia.com>
Date: Mon, 7 Apr 2025 15:23:41 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	zyjzyj2000@...il.com, leon@...nel.org, matsuda-daisuke@...itsu.com,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>
Subject: Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check

On Wed, Apr 02, 2025 at 11:26:57AM +0800, Li Zhijian wrote:
> The blktests/rnbd reported a null pointer dereference as following.
> Similar to the mxl5, introduce a is_odp_mr() to check if the odp
> is enabled in this mr.
> 
> Workqueue: rxe_wq do_work [rdma_rxe]
> RIP: 0010:rxe_mr_copy+0x57/0x210 [rdma_rxe]
> Code: 7c 04 48 89 f3 48 89 d5 41 89 cf 45 89 c4 0f 84 dc 00 00 00 89 ca e8 f8 f8 ff ff 85 c0 0f 85 75 01 00 00 49 8b 86 f0 00 00 00 <f6> 40 28 02 0f 85 98 01 00 00 41 8b 46 78 41 8b 8e 10 01 00 00 8d
> RSP: 0018:ffffa0aac02cfcf8 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffff9079cd440024 RCX: 0000000000000000
> RDX: 000000000000003c RSI: ffff9079cd440060 RDI: ffff9079cd665600
> RBP: ffff9079c0e5e45a R08: 0000000000000000 R09: 0000000000000000
> R10: 000000003c000000 R11: 0000000000225510 R12: 0000000000000000
> R13: 0000000000000000 R14: ffff9079cd665600 R15: 000000000000003c
> FS:  0000000000000000(0000) GS:ffff907ccfa80000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000028 CR3: 0000000119498001 CR4: 00000000001726f0
> Call Trace:
>  <TASK>
>  ? __die_body+0x1e/0x60
>  ? page_fault_oops+0x14f/0x4c0
>  ? rxe_mr_copy+0x57/0x210 [rdma_rxe]
>  ? search_bpf_extables+0x5f/0x80
>  ? exc_page_fault+0x7e/0x180
>  ? asm_exc_page_fault+0x26/0x30
>  ? rxe_mr_copy+0x57/0x210 [rdma_rxe]
>  ? rxe_mr_copy+0x48/0x210 [rdma_rxe]
>  ? rxe_pool_get_index+0x50/0x90 [rdma_rxe]
>  rxe_receiver+0x1d98/0x2530 [rdma_rxe]
>  ? psi_task_switch+0x1ff/0x250
>  ? finish_task_switch+0x92/0x2d0
>  ? __schedule+0xbdf/0x17c0
>  do_task+0x65/0x1e0 [rdma_rxe]
>  process_scheduled_works+0xaa/0x3f0
>  worker_thread+0x117/0x240
> 
> Fixes: d03fb5c6599e ("RDMA/rxe: Allow registering MRs for On-Demand Paging")
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> Reviewed-by: Daisuke Matsuda <matsuda-daisuke@...itsu.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> ---
>  drivers/infiniband/sw/rxe/rxe_loc.h  | 6 ++++++
>  drivers/infiniband/sw/rxe/rxe_mr.c   | 4 ++--
>  drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--
>  3 files changed, 10 insertions(+), 4 deletions(-)

Applied to for-rc, thanks

Jason