linux-kernel - Re: [PATCH] x86/resctrl: Fix rdtgroup_mkdir()'s unlocked use of kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_QYwMn5dAcTOglC@gmail.com>
Date: Mon, 7 Apr 2025 20:26:08 +0200
From: Ingo Molnar <mingo@...nel.org>
To: James Morse <james.morse@....com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Tony Luck <tony.luck@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, babu.moger@....com,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] x86/resctrl: Fix rdtgroup_mkdir()'s unlocked use of
 kernfs_node::name


* James Morse <james.morse@....com> wrote:

> +	/*
> +	 * Check the parent directory for a monitor group is a "mon_groups"
> +	 * directory.
> +	 */

This sentence probably wants to be a bit less linguistically ambiguous, 
via something like:

  s/Check the parent directory for a monitor group is a "mon_groups" directory.
   /Check that the parent directory for a monitor group is a "mon_groups" directory.

With that:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo