linux-kernel - Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64a3cd3b-feee-4414-8569-01642b127ac8@lunn.ch>
Date: Mon, 7 Apr 2025 22:18:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, nm@...com, ssantosh@...nel.org,
	tony@...mide.com, richardcochran@...il.com, glaroque@...libre.com,
	schnelle@...ux.ibm.com, m-karicheri2@...com, rdunlap@...radead.org,
	diogo.ivo@...mens.com, basharath@...thit.com, horms@...nel.org,
	jacob.e.keller@...el.com, m-malladi@...com,
	javier.carrasco.cruz@...il.com, afd@...com, s-anna@...com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, pratheesh@...com, prajith@...com,
	vigneshr@...com, praneeth@...com, srk@...com, rogerq@...com,
	krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com
Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support
 for ICSSM PRUETH Driver

> +#define PRUETH_MODULE_VERSION "0.2"

> +static void icssm_emac_get_drvinfo(struct net_device *ndev,
> +				   struct ethtool_drvinfo *info)
> +{
> +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info->driver));
> +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));

Driver version numbers are pointless, they never change, but the
kernel is changing all the time. Leave version blank, and the core
will fill in the kernel version, which is useful.

     Andrew