linux-kernel - RE: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089CB4D35150C286EE81387D6AA2@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 7 Apr 2025 21:47:10 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Andrew Lunn <andrew@...n.ch>, Parvathi Pudi <parvathi@...thit.com>
CC: "danishanwar@...com" <danishanwar@...com>, "rogerq@...nel.org"
	<rogerq@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "Dumazet, Eric"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "nm@...com" <nm@...com>, "ssantosh@...nel.org"
	<ssantosh@...nel.org>, "tony@...mide.com" <tony@...mide.com>,
	"richardcochran@...il.com" <richardcochran@...il.com>,
	"glaroque@...libre.com" <glaroque@...libre.com>, "schnelle@...ux.ibm.com"
	<schnelle@...ux.ibm.com>, "m-karicheri2@...com" <m-karicheri2@...com>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>, "diogo.ivo@...mens.com"
	<diogo.ivo@...mens.com>, "basharath@...thit.com" <basharath@...thit.com>,
	"horms@...nel.org" <horms@...nel.org>, "m-malladi@...com" <m-malladi@...com>,
	"javier.carrasco.cruz@...il.com" <javier.carrasco.cruz@...il.com>,
	"afd@...com" <afd@...com>, "s-anna@...com" <s-anna@...com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-omap@...r.kernel.org"
	<linux-omap@...r.kernel.org>, "pratheesh@...com" <pratheesh@...com>,
	"prajith@...com" <prajith@...com>, "vigneshr@...com" <vigneshr@...com>,
	"praneeth@...com" <praneeth@...com>, "srk@...com" <srk@...com>,
	"rogerq@...com" <rogerq@...com>, "krishna@...thit.com" <krishna@...thit.com>,
	"pmohan@...thit.com" <pmohan@...thit.com>, "mohan@...thit.com"
	<mohan@...thit.com>
Subject: RE: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support
 for ICSSM PRUETH Driver



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, April 7, 2025 1:19 PM
> To: Parvathi Pudi <parvathi@...thit.com>
> Cc: danishanwar@...com; rogerq@...nel.org; andrew+netdev@...n.ch;
> davem@...emloft.net; Dumazet, Eric <edumazet@...gle.com>;
> kuba@...nel.org; pabeni@...hat.com; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; nm@...com; ssantosh@...nel.org; tony@...mide.com;
> richardcochran@...il.com; glaroque@...libre.com; schnelle@...ux.ibm.com;
> m-karicheri2@...com; rdunlap@...radead.org; diogo.ivo@...mens.com;
> basharath@...thit.com; horms@...nel.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; m-malladi@...com; javier.carrasco.cruz@...il.com;
> afd@...com; s-anna@...com; linux-arm-kernel@...ts.infradead.org;
> netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-omap@...r.kernel.org; pratheesh@...com;
> prajith@...com; vigneshr@...com; praneeth@...com; srk@...com; rogerq@...com;
> krishna@...thit.com; pmohan@...thit.com; mohan@...thit.com
> Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for
> ICSSM PRUETH Driver
> 
> > +#define PRUETH_MODULE_VERSION "0.2"
> 
> > +static void icssm_emac_get_drvinfo(struct net_device *ndev,
> > +				   struct ethtool_drvinfo *info)
> > +{
> > +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info-
> >driver));
> > +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));
> 
> Driver version numbers are pointless, they never change, but the
> kernel is changing all the time. Leave version blank, and the core
> will fill in the kernel version, which is useful.
> 
>      Andrew

It is also a long standing policy that in-tree drivers should not have versions separate from the kernel version.

Thanks,
Jake