linux-kernel - Re: objtool warning in ice_free_prof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ficwjo5aa6enekhu6nsmsi5vfp6ms7dgyc326yqknda22pthdn@puk4cdrmem23>
Date: Mon, 7 Apr 2025 14:42:51 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Oleksandr Natalenko <oleksandr@...alenko.name>
Cc: linux-kernel@...r.kernel.org, 
	Przemek Kitszel <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, 
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, 
	Andrew Lunn <andrew+netdev@...n.ch>, Tony Nguyen <anthony.l.nguyen@...el.com>, 
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: objtool warning in ice_free_prof_mask

On Mon, Apr 07, 2025 at 11:21:27AM +0200, Oleksandr Natalenko wrote:
> It's not a new warning, I've observe it for several recent major kernel releases already.
> 
> I do not build with CONFIG_COMPILE_TEST.
> 
> I've also realised I see this warning with -O3 only. I know this is
> unsupported, so feel free to ignore me, but I do -O3 builds for
> finding out possible loose ends in the code, and this is the only
> place where it breaks.
> 
> > > ```
> > > drivers/net/ethernet/intel/ice/ice.o: error: objtool: ice_free_prof_mask.isra.0() falls through to next function ice_free_flow_profs.cold()
> > > drivers/net/ethernet/intel/ice/ice.o: error: objtool: ice_free_prof_mask.isra.0.cold() is missing an ELF size annotation
> > > ```
> > > 
> > > If I mark ice_write_prof_mask_reg() as noinline, this warning disappears.
> > > 
> > > Any idea what's going wrong?

This type of error usually means some type of undefined behavior.  Can
you share your config?  No guarantees since it is -O3 after all, but I
can still take a look to see if it's pointing to a bug of some kind.

-- 
Josh