[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee5feee4-e74a-4dc6-ad8e-42cf9c81cb3c@mendozajonas.com>
Date: Tue, 8 Apr 2025 07:44:37 +1000
From: Sam Mendoza-Jonas <sam@...dozajonas.com>
To: kalavakunta.hari.prasad@...il.com, fercerpav@...il.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: npeacock@...a.com, akozlov@...a.com
Subject: Re: [PATCH net-next 0/2] GCPS Spec Compliance Patch Set
On 8/04/2025 4:19 am, kalavakunta.hari.prasad@...il.com wrote:
> From: Hari Kalavakunta <kalavakunta.hari.prasad@...il.com>
>
> Make Get Controller Packet Statistics (GCPS) 64-bit member variables
> spec-compliant, as per DSP0222 v1.0.0 and forward specs
>
> Hari Kalavakunta (2):
> net: ncsi: Format structure for longer names
> net: ncsi: Fix GCPS 64-bit member variables
>
> net/ncsi/internal.h | 21 +++++-----
> net/ncsi/ncsi-pkt.h | 95 +++++++++++++++++++++++++--------------------
> net/ncsi/ncsi-rsp.c | 31 +++++++++------
> 3 files changed, 82 insertions(+), 65 deletions(-)
Looking at e.g. DSP0222 1.2.0a, you're right about the field widths, but
it's not particularly explicit about whether the full 64 bits is used.
I'd assume so, but do you see the upper bits of e.g. the packet counters
return expected data? Otherwise looks good.
Acked-by: Samuel Mendoza-Jonas <sam@...dozajonas.com>
Powered by blists - more mailing lists