linux-kernel - Re: [PATCH v3] staging: rtl8723bs: Use % 4096u instead of & 0xfff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADYq+fZzzJTEvhbO9y=i2DA7fH_99ofcG-PZHP_7LR1pyhympA@mail.gmail.com>
Date: Mon, 7 Apr 2025 07:32:18 +0100
From: Samuel Abraham <abrahamadekunle50@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Julia Lawall <julia.lawall@...ia.fr>, outreachy@...ts.linux.dev, andy@...nel.org, 
	dan.carpenter@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: Use % 4096u instead of & 0xfff

On Mon, Apr 7, 2025 at 6:10 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Mon, Apr 07, 2025 at 12:27:53AM +0000, Abraham Samuel Adekunle wrote:
> > The sequence number is constrained to a range of [0, 4095], which
> > is a total of 4096 values. The bitmask operation using `0xfff` is
> > used to perform this wrap-around. While this is functionally correct,
> > it obscures the intended semantic of a 4096-based wrap.
> >
> > Using a modulo operation with `4096u` makes the wrap-around logic
> > explicit and easier to understand. It clearly signals that the sequence
> > number cycles though a range of 4096 values.
> >
> > The use of `4096u` also guarantees that the modulo operation is performed
> > with unsigned arithmetic, preventing potential issues with signed types.
> >
> > Suggested-by: Andy Shevchenko <andy@...nel.org>
> > David Laight <david.laight.linux@...il.com>
> >
> > Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
> > ---
> > Changes in v2:
> >       - Changed the commit message to a more descriptive message which
> >       makes it clear why the patch does the change.
> >       - Changed the subject title to include `4096u` to show that an unsigned
> >       module is used.
> > Changes in v1:
> >       - Added more patch recipients.
> >
> >  drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
>
> Any specific reason you did not include the staging mailing list like
> scripts/get_maintainers.pl asks you to?

Thank you, Greg.
I have sent an updated patch.

Adekunle