linux-kernel - Re: [V1,03/12] media: mediatek: jpeg: add jpeg compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3671876175ad1f627caa554b5fbe0a04239adc31.camel@mediatek.com>
Date: Mon, 7 Apr 2025 07:15:42 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "matthias.bgg@...il.com" <matthias.bgg@...il.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "robh+dt@...nel.org"
	<robh+dt@...nel.org>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"tzungbi@...omium.org" <tzungbi@...omium.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"kyrie.wu@...iatek.corp-partner.google.com"
	<kyrie.wu@...iatek.corp-partner.google.com>,
	Bin Liu (刘彬) <bin.liu@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>
Subject: Re: [V1,03/12] media: mediatek: jpeg: add jpeg compatible

On Fri, 2025-01-10 at 10:46 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 09/01/25 14:35, kyrie.wu ha scritto:
> > Add jpeg dec and enc compatible for mt8196
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@...iatek.com>
> > ---
> >   drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c   | 8
> > ++++++++
> >   drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 3 +++
> >   drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 3 +++
> >   3 files changed, 14 insertions(+)
> > 
> > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> > b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> > index 9517ebed0701..c3ccc525d9fd 100644
> > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> > @@ -1996,6 +1996,14 @@ static const struct of_device_id
> > mtk_jpeg_match[] = {
> >               .compatible = "mediatek,mt8188-jpgdec",
> >               .data = &mtk8188_jpegdec_drvdata,
> >       },
> > +     {
> > +             .compatible = "mediatek,mt8196-jpgenc",
> > +             .data = &mtk8195_jpegenc_drvdata,
> > +     },
> > +     {
> > +             .compatible = "mediatek,mt8196-jpgdec",
> > +             .data = &mtk8195_jpegdec_drvdata,
> 
> You're adding this with MT8195 platform data, and then you're
> changing it to
> MT8196 specific platform data.
> 
> Just put this commit at the end of the series, at this point.
> 
> Regards,
> Angelo

Dear Angelo,

Thanks for your advices, I will add smmu info. into the platform data
and push it to the end.

Thanks.

Regards,
Kyrie.

> 
> > +     },
> >       {},
> >   };
> > 
> > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> > b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> > index ebded06ba92d..d868e46aaf37 100644
> > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> > @@ -45,6 +45,9 @@ static const struct of_device_id
> > mtk_jpegdec_hw_ids[] = {
> >       {
> >               .compatible = "mediatek,mt8195-jpgdec-hw",
> >       },
> > +     {
> > +             .compatible = "mediatek,mt8196-jpgdec-hw",
> > +     },
> >       {},
> >   };
> >   MODULE_DEVICE_TABLE(of, mtk_jpegdec_hw_ids);
> > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> > b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> > index 87fe1f324f23..ca06d4f435cd 100644
> > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c
> > @@ -52,6 +52,9 @@ static const struct of_device_id
> > mtk_jpegenc_drv_ids[] = {
> >       {
> >               .compatible = "mediatek,mt8195-jpgenc-hw",
> >       },
> > +     {
> > +             .compatible = "mediatek,mt8196-jpgenc-hw",
> > +     },
> >       {},
> >   };
> >   MODULE_DEVICE_TABLE(of, mtk_jpegenc_drv_ids);
> 
> 
>