linux-kernel - Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dacb76d-c227-4373-93db-4255c3f9ac83@kernel.org>
Date: Mon, 7 Apr 2025 09:19:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "mchehab@...nel.org" <mchehab@...nel.org>,
 "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
 "tzungbi@...omium.org" <tzungbi@...omium.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "kyrie.wu@...iatek.corp-partner.google.com"
 <kyrie.wu@...iatek.corp-partner.google.com>,
 Bin Liu (刘彬) <bin.liu@...iatek.com>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec
 compatible

On 07/04/2025 09:13, Kyrie Wu (吴晗) wrote:
> On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:

...


>>>
>>>  properties:
>>>    compatible:
>>> -    const: mediatek,mt8195-jpgdec
>>> +    enum:
>>> +      - mediatek,mt8195-jpgdec
>>> +      - mediatek,mt8196-jpgdec
>>
>> Devices look compatible, so express it with fallback.
>>
>> Best regards,
>> Krzysztof
> 
> Dear Krzysztof,
> 
> The MT8195 and MT8196 are both multi-hardware chips, I renamed the file
> to treat it as a common file, if I don't do that it will need to
> recreate a file with similar contents. Is this acceptable?

No, do not create own rules. I do not see how this is related to my
comment at all.

You responded three months after my review, so entire context including
actual mails in my inbox are gone.

If you disagree with feedback, respond in timely manner. I feel
discussing something after three months like wasting my time.


> If the above description is acceptable, I will apply your request in
> the next version.

Best regards,
Krzysztof