[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z_OSQzA04-5v7SR0@ryzen>
Date: Mon, 7 Apr 2025 10:52:19 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Igor Pylypiv <ipylypiv@...gle.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field
consistently
On Fri, Apr 04, 2025 at 12:18:16PM -0700, Igor Pylypiv wrote:
>
> Agree. ATA Status Return sense data descriptor for ATA PASS-THOUGH commands
> already contains the ATA LBA in bytes [6..11] so it seems redundant to
> also include the same in the Information sense data descriptor.
Damien and I talked about this.
Since this patch only affects non-PT commands, what it this patch actually
solving?
Since for non-PT commands, sense data is not returned to the user.
So unless SCSI core does some specific handling based on the INFORMATION
field (and AFAICT, SCSI core only looks at SK/ASC/ASCQ), I can't see how
this patch can actually solve anything.
Kind regards,
Niklas
Powered by blists - more mailing lists