linux-kernel - Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_OaafNRHhTiBzFG@ryzen>
Date: Mon, 7 Apr 2025 11:27:05 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Igor Pylypiv <ipylypiv@...gle.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field
 consistently

On Mon, Apr 07, 2025 at 10:03:54AM +0200, Niklas Cassel wrote:
> 
> If we look at the ATA Sense Data for Successful NCQ Commands log,
> it has a bunch of Sense Data descriptors.
> 
> ACS-6, 9.29.3 Successful Sense Data descriptor,
> does have the LBA field and an INFORMATION field.
> 
> The definition of the INFORMATION field in the Successful Sense Data
> descriptor:
> 
> """
> 9.29.3.5 INFORMATION field
> If definition of the sense data to be returned when a command completes
> without an error includes an information value, then the INFORMATION field
> contains the defined value. Otherwise, the INFORMATION field is reserved.
> """

Side note:
Considering that this is just two bytes, and the INFORMATION field in SCSI
is four bytes, I honestly have no idea what this field actually contains.

Anyway, the biggest question is what actual problem this fixes, since the
sense data is not returned to the user for non-passthrough commands.


Kind regards,
Niklas