linux-kernel - Re: [PATCH v2 22/30] panel/newvision-nv3052c: Use refcounted allocation in place of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc9ebbfc-7227-412b-b1d6-9ccfb393658f@linaro.org>
Date: Mon, 7 Apr 2025 11:56:11 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Anusha Srivatsa <asrivats@...hat.com>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Icenowy Zheng <icenowy@...c.io>, Jagan Teki <jagan@...rulasolutions.com>,
 Ondrej Jirman <megi@....cz>, Javier Martinez Canillas <javierm@...hat.com>,
 Michael Trimarchi <michael@...rulasolutions.com>,
 Michael Walle <mwalle@...nel.org>, Jagan Teki <jagan@...eble.ai>,
 Guido Günther <agx@...xcpu.org>,
 Purism Kernel Team <kernel@...i.sm>, Linus Walleij
 <linus.walleij@...aro.org>, Jianhua Lu <lujianhua000@...il.com>,
 Stefan Mavrodiev <stefan@...mex.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 22/30] panel/newvision-nv3052c: Use refcounted
 allocation in place of devm_kzalloc()

On 03/04/2025 16:16, Anusha Srivatsa wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
> 
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
> v2: none.
> ---
>   drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 06e16a7c14a756b9a399347b29b410fd5f4ae273..08c99a48e06dc02677c6f0575d344f890871e0af 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -777,9 +777,10 @@ static int nv3052c_probe(struct spi_device *spi)
>   	struct nv3052c *priv;
>   	int err;
>   
> -	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> -	if (!priv)
> -		return -ENOMEM;
> +	priv = devm_drm_panel_alloc(dev, struct nv3052c, panel, &nv3052c_funcs,
> +				DRM_MODE_CONNECTOR_DPI);

Wrong alignment here

Neil

> +	if (IS_ERR(priv))
> +		return PTR_ERR(priv);
>   
>   	priv->dev = dev;
>   
> @@ -803,9 +804,6 @@ static int nv3052c_probe(struct spi_device *spi)
>   
>   	spi_set_drvdata(spi, priv);
>   
> -	drm_panel_init(&priv->panel, dev, &nv3052c_funcs,
> -		       DRM_MODE_CONNECTOR_DPI);
> -
>   	err = drm_panel_of_backlight(&priv->panel);
>   	if (err)
>   		return dev_err_probe(dev, err, "Failed to attach backlight\n");
>