linux-kernel - Re: [PATCH v2 13/30] panel/jadard-jd9365da-h3: Use refcounted allocation in place of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b5d8f63-d888-4f0c-91a3-216ef9d95d19@linaro.org>
Date: Mon, 7 Apr 2025 11:56:32 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Anusha Srivatsa <asrivats@...hat.com>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Icenowy Zheng <icenowy@...c.io>, Jagan Teki <jagan@...rulasolutions.com>,
 Ondrej Jirman <megi@....cz>, Javier Martinez Canillas <javierm@...hat.com>,
 Michael Trimarchi <michael@...rulasolutions.com>,
 Michael Walle <mwalle@...nel.org>, Jagan Teki <jagan@...eble.ai>,
 Guido Günther <agx@...xcpu.org>,
 Purism Kernel Team <kernel@...i.sm>, Linus Walleij
 <linus.walleij@...aro.org>, Jianhua Lu <lujianhua000@...il.com>,
 Stefan Mavrodiev <stefan@...mex.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/30] panel/jadard-jd9365da-h3: Use refcounted
 allocation in place of devm_kzalloc()

On 03/04/2025 16:16, Anusha Srivatsa wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
> 
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
> v2: none.
> ---
>   drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 7d68a8acfe2ea45a913dff25eb5e9f0663503f08..6b02923de3f0778f45a6f9ce20d70d667772c64c 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -1120,9 +1120,10 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>   	struct jadard *jadard;
>   	int ret;
>   
> -	jadard = devm_kzalloc(&dsi->dev, sizeof(*jadard), GFP_KERNEL);
> -	if (!jadard)
> -		return -ENOMEM;
> +	jadard = devm_drm_panel_alloc(dev, struct jadard, panel, &jadard_funcs,
> +				   DRM_MODE_CONNECTOR_DSI);

Wrong alignment

Neil

> +	if (IS_ERR(jadard))
> +		return PTR_ERR(jadard);
>   
>   	desc = of_device_get_match_data(dev);
>   	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> @@ -1148,9 +1149,6 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>   		return PTR_ERR(jadard->vccio);
>   	}
>   
> -	drm_panel_init(&jadard->panel, dev, &jadard_funcs,
> -		       DRM_MODE_CONNECTOR_DSI);
> -
>   	ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
>   	if (ret < 0)
>   		return dev_err_probe(dev, ret, "failed to get orientation\n");
>