linux-kernel - Re: [PATCH 3/5] arm64: dts: ti: k3-j721e-sk: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250408121723.ksjtilh4hxl2wh34@derail>
Date: Tue, 8 Apr 2025 07:17:23 -0500
From: Nishanth Menon <nm@...com>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>
CC: <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <vaishnav.a@...com>,
        <jai.luthra@...ux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <imx@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH 3/5] arm64: dts: ti: k3-j721e-sk: Fix dtbs_check warnings
 in IMX219 overlay

On 14:31-20250408, Yemike Abhilash Chandra wrote:
> Hi Nishanth,
> 
> On 07/04/25 19:15, Nishanth Menon wrote:
> > $subject - the patch adds description for the supplies for the sensor.
> > Please fix the description.
> > 
> 
> In this patch, I am addressing all dtbs_check warnings generated from this
> overlay:
> 
> 1. Adding the missing regulator node
> 2. Removing the incorrectly added clock-names property
> 
> Due to the inclusion of both changes, I opted for a more generic commit
> title.
> Please let me know if you want me to split this patch into two separate
> patches
> with specific commit titles and commit messages.

subject line should indicate what we are fixing here. If the commit
message indicates two different problems that were to be fixed, it is
better to do that in two different commits. Generic subject line is hard
to gork to understand if it is critical or not.

Do not forget ./Documentation/process/stable-kernel-rules.rst and use
fixes: tag as appropriate to indicate the original problem patch
which is being fixed.


[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D