linux-kernel - Re: [PATCH v2] iio: adc: stm32: add oversampling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0550fb58-cff3-47fd-b5f4-cbc19113436c@baylibre.com>
Date: Tue, 8 Apr 2025 09:43:11 -0500
From: David Lechner <dlechner@...libre.com>
To: Olivier MOYSAN <olivier.moysan@...s.st.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: Fabrice Gasnier <fabrice.gasnier@...s.st.com>, linux-iio@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: adc: stm32: add oversampling support

On 4/7/25 11:07 AM, Olivier MOYSAN wrote:
> Hi David,
> 
> Thanks for reviewing,
> 
> On 4/4/25 18:15, David Lechner wrote:
>> On 4/3/25 11:23 AM, Olivier Moysan wrote:

...

>>> +#define STM32H7_OVSR_MASK        GENMASK(25, 16) /* Correspond to OSVR field in datasheet */
>>
>> nit: Comment seems obvious and can be left out.
>>
> 
> Oversampling bit name is "OSVR" in datasheet H7, while oversampling shift is "OVSS". For naming consistency, I used OVSR instead of OSVR,
> and highlighted it with a comment. As an alternative, STM32H7_OVSR could be renamed, but I would rather keep it unchanged.
> 

Ah, my eyes do not easily see the difference between OSVR and OVSR.

Makes sense to keep it so grep picks up both spellings.