linux-kernel - Re: [PATCH v3 6/7] i2c: core: Deprecate of_node in struct i2c_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_U162kNEPSZI3zD@kekkonen.localdomain>
Date: Tue, 8 Apr 2025 14:42:51 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Jai Luthra <jai.luthra@...asonboard.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v3 6/7] i2c: core: Deprecate of_node in struct
 i2c_board_info

Hi Andy,

On Mon, Apr 07, 2025 at 06:45:02PM +0300, Andy Shevchenko wrote:
> Two members of the same or similar semantics is quite confusing to begin with.
> Moreover, the fwnode covers all possible firmware descriptions that Linux kernel
> supports. Deprecate of_node in struct i2c_board_info, so users will be warned
> and in the future remote it completely.

Too long lines, should be up to 75 characters long only.

> 
> Tested-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/i2c.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 2e4903b7f7bc..cc1437f29823 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -405,7 +405,7 @@ static inline bool i2c_detect_slave_mode(struct device *dev) { return false; }
>   * @addr: stored in i2c_client.addr
>   * @dev_name: Overrides the default <busnr>-<addr> dev_name if set
>   * @platform_data: stored in i2c_client.dev.platform_data
> - * @of_node: pointer to OpenFirmware device node
> + * @of_node: **DEPRECATED** - use @fwnode for this
>   * @fwnode: device node supplied by the platform firmware
>   * @swnode: software node for the device
>   * @resources: resources associated with the device

-- 
Regards,

Sakari Ailus