linux-kernel - Re: [PATCH hyperv-next v7 01/11] arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9bea07c-3a0e-41bb-a8d8-12d9f8776e07@linux.microsoft.com>
Date: Tue, 8 Apr 2025 09:16:16 -0700
From: Roman Kisel <romank@...ux.microsoft.com>
To: Marc Zyngier <maz@...nel.org>
Cc: arnd@...db.de, bhelgaas@...gle.com, bp@...en8.de,
 catalin.marinas@....com, conor+dt@...nel.org, dan.carpenter@...aro.org,
 dave.hansen@...ux.intel.com, decui@...rosoft.com, haiyangz@...rosoft.com,
 hpa@...or.com, joey.gouly@....com, krzk+dt@...nel.org, kw@...ux.com,
 kys@...rosoft.com, lenb@...nel.org, lpieralisi@...nel.org,
 manivannan.sadhasivam@...aro.org, mark.rutland@....com, mingo@...hat.com,
 oliver.upton@...ux.dev, rafael@...nel.org, robh@...nel.org,
 rafael.j.wysocki@...el.com, ssengar@...ux.microsoft.com,
 sudeep.holla@....com, suzuki.poulose@....com, tglx@...utronix.de,
 wei.liu@...nel.org, will@...nel.org, yuzenghui@...wei.com,
 devicetree@...r.kernel.org, kvmarm@...ts.linux.dev,
 linux-acpi@...r.kernel.org, linux-arch@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-hyperv@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, x86@...nel.org,
 apais@...rosoft.com, benhill@...rosoft.com, bperkins@...rosoft.com,
 sunilmut@...rosoft.com
Subject: Re: [PATCH hyperv-next v7 01/11] arm64: kvm, smccc: Introduce and use
 API for getting hypervisor UUID



On 4/8/2025 12:06 AM, Marc Zyngier wrote:
> On Mon, 07 Apr 2025 21:13:26 +0100,
> Roman Kisel <romank@...ux.microsoft.com> wrote:

[...]

>>   
>>   #include <linux/args.h>
>>   #include <linux/init.h>
>> +
>> +#ifndef __ASSEMBLER__
>> +#include <linux/uuid.h>
>> +#endif
> 
> That's a pretty unusual guard in arm64 land. Looking at the current
> state of the kernel:
> 
> $ git grep -w __ASSEMBLER__ arch/arm64/ | wc -l
> 2
> $ git grep -w __ASSEMBLY__ arch/arm64/ | wc -l
> 122
> 
> I'd suggest the later rather than the former.

Thanks for catching this! I'll be sure to change this to use the arm64
coding conventions in the next version.

> 
> Thanks,
> 
> 	M.
> 

-- 
Thank you,
Roman