linux-kernel - Re: [RESEND PATCH] clk: socfpga: clk-pll: Optimize local variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0BD7D71D-6F6B-4864-BEA7-E13563908D62@linux.dev>
Date: Tue, 8 Apr 2025 19:45:55 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Dinh Nguyen <dinguyen@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] clk: socfpga: clk-pll: Optimize local variables

Hi Dinh,

On 19. Feb 2025, at 13:42, Dinh Nguyen wrote:
> On 2/19/25 04:42, Thorsten Blum wrote:
>> Since readl() returns a u32, the local variables reg and bypass can also
>> have the data type u32. Furthermore, divf and divq are derived from reg
>> and can also be a u32.
>> Since do_div() casts the divisor to u32 anyway, changing the data type
>> of divq to u32 removes the following Coccinelle/coccicheck warning
>> reported by do_div.cocci:
>>  WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead
>> Compile-tested only.
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
>> drivers/clk/socfpga/clk-pll.c | 4 ++--
> 
> Applied!

Did this patch and [*] get lost somehow?

They aren't in -next and also didn't make it into the last merge window.

Thanks,
Thorsten

[*] https://lore.kernel.org/lkml/20250219104435.1525-2-thorsten.blum@linux.dev/