linux-kernel - Re: [PATCH v4 0/4] objtool: Fix INSN_CONTEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_TM9yXoMrsB0AEz@gmail.com>
Date: Tue, 8 Apr 2025 09:15:03 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH v4 0/4] objtool: Fix INSN_CONTEXT_SWITCH


* Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Josh Poimboeuf <jpoimboe@...nel.org> wrote:
> 
> > I decided to keep the "unsupported instruction in callable function"
> > warning, it's not hurting anything.  As a result we now have
> > INSN_SYSCALL and INSN_SYSRET.
> > 
> > v4:
> > - split up patches
> > - don't get rid of "unsupported instruction in callable function" warning
> > - split INSN_CONTEXT_SWITCH -> INSN_SYSCALL / INSN_SYSRET
> > 
> > v3: https://lore.kernel.org/9b23e4413873bee38961e628b0c73f6d3a26d494.1743799705.git.jpoimboe@kernel.org
> > 
> > Josh Poimboeuf (4):
> >   objtool: Fix INSN_CONTEXT_SWITCH handling in validate_unret()
> >   objtool: Split INSN_CONTEXT_SWITCH into INSN_SYSCALL and INSN_SYSRET
> >   objtool: Stop UNRET validation on UD2
> >   objtool, xen: Fix INSN_SYSCALL / INSN_SYSRET semantics
> > 
> >  arch/x86/xen/xen-asm.S               |  4 +---
> >  tools/objtool/arch/x86/decode.c      | 18 ++++++++++-------
> >  tools/objtool/check.c                | 29 +++++++++++++++++++++-------
> >  tools/objtool/include/objtool/arch.h |  3 ++-
> >  4 files changed, 36 insertions(+), 18 deletions(-)
> 
> I'm wondering about the timing: can this wait for v6.16, or does it 
> trigger on some popular config/build-tools combination?

On a second look, I think these fixes should go upstream now, so I've 
applied them to tip:objtool/urgent.

Thanks,

	Ingo