linux-kernel - Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5feaca10-f3bc-49bb-8e5b-9d9efa918e16@opensource.cirrus.com>
Date: Wed, 9 Apr 2025 15:34:27 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com, kunit-dev@...glegroups.com,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

On 09/04/2025 3:24 pm, Mark Brown wrote:
> On Wed, Apr 09, 2025 at 11:45:44AM +0100, Richard Fitzgerald wrote:
>> Depend on SND_SOC_CS_AMP_LIB instead of selecting it.
>>
>> KUNIT_ALL_TESTS should only build tests for components that are
>> already being built, it should not cause other stuff to be added
>> to the build.
> 
>>   config SND_SOC_CS_AMP_LIB_TEST
>> -	tristate "KUnit test for Cirrus Logic cs-amp-lib"
>> -	depends on KUNIT
>> +	tristate "KUnit test for Cirrus Logic cs-amp-lib" if !KUNIT_ALL_TESTS
>> +	depends on SND_SOC_CS_AMP_LIB && KUNIT
>>   	default KUNIT_ALL_TESTS
>> -	select SND_SOC_CS_AMP_LIB
>>   	help
>>   	  This builds KUnit tests for the Cirrus Logic common
>>   	  amplifier library.
> 
> This by itself results in the Cirrus tests being removed from a kunit
> --alltests run which is a regression in coverage.  I'd expect to see
> some corresponding updates in the KUnit all_tests.config to keep them
> enabled.

That's the defined behaviour of KUNIT_ALL_TESTS. It shouldn't have been
running as part of an alltests if nothing had selected it. That seems to
make people angry. Probably the same people who would complain if there
was a bug in the code that they didn't want to test.