linux-kernel - Re: [PATCH v1] um: fix incompatible argument type in iounmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWtgSjxeGYJVNzeWPOCd9nUWeKQnCtFQaROQ1o=r_-QwQ@mail.gmail.com>
Date: Wed, 9 Apr 2025 19:07:56 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>, richard@....at, 
	anton.ivanov@...bridgegreys.com, johannes@...solutions.net, 
	linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, Logan Gunthorpe <logang@...tatee.com>, 
	Stephen Bates <sbates@...thlin.com>, Danilo Krummrich <dakr@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1] um: fix incompatible argument type in iounmap()

Hi Miguel,

CC arnd

On Wed, 9 Apr 2025 at 16:48, Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> On Wed, Apr 9, 2025 at 8:16 AM FUJITA Tomonori
> <fujita.tomonori@...il.com> wrote:
> >
> > Align iounmap() signature with other architectures.
>
> Most indeed have `volatile`, but nios2 and m68k don't -- Cc'ing them
> just in case.

Indeed. Apparently the volatile keyword has not always been there...
Why does iounmap() need the volatile keyword?
Why does pci_iounmap() not have the volatile keyword?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds