linux-kernel - Re: [PATCH v1] um: fix incompatible argument type in iounmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_auq9XEUxMwKVoN@cassiopeiae>
Date: Wed, 9 Apr 2025 19:30:19 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	FUJITA Tomonori <fujita.tomonori@...il.com>, richard@....at,
	anton.ivanov@...bridgegreys.com, johannes@...solutions.net,
	linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
	rust-for-linux@...r.kernel.org,
	Logan Gunthorpe <logang@...tatee.com>,
	Stephen Bates <sbates@...thlin.com>,
	Dinh Nguyen <dinguyen@...nel.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1] um: fix incompatible argument type in iounmap()

On Wed, Apr 09, 2025 at 07:07:56PM +0200, Geert Uytterhoeven wrote:
> Hi Miguel,
> 
> CC arnd
> 
> On Wed, 9 Apr 2025 at 16:48, Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
> > On Wed, Apr 9, 2025 at 8:16 AM FUJITA Tomonori
> > <fujita.tomonori@...il.com> wrote:
> > >
> > > Align iounmap() signature with other architectures.
> >
> > Most indeed have `volatile`, but nios2 and m68k don't -- Cc'ing them
> > just in case.
> 
> Indeed. Apparently the volatile keyword has not always been there...
> Why does iounmap() need the volatile keyword?
> Why does pci_iounmap() not have the volatile keyword?

I think none of the functions within rust/helpers/io.c need volatile, since they
just defer to the corresponding C function / macro.

This probably has been a copy/paste mistake of the function signatures and
should be removed instead.

- Danilo