linux-kernel - Re: [PATCH v3 10/14] x86: Update the KASAN non-canonical hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe8192a9-02ba-40c9-9ba9-8582547cd3f4@intel.com>
Date: Wed, 9 Apr 2025 11:29:30 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
Cc: hpa@...or.com, hch@...radead.org, nick.desaulniers+lkml@...il.com,
 kuan-ying.lee@...onical.com, masahiroy@...nel.org,
 samuel.holland@...ive.com, mingo@...hat.com, corbet@....net,
 ryabinin.a.a@...il.com, guoweikang.kernel@...il.com, jpoimboe@...nel.org,
 ardb@...nel.org, vincenzo.frascino@....com, glider@...gle.com,
 kirill.shutemov@...ux.intel.com, apopple@...dia.com,
 samitolvanen@...gle.com, kaleshsingh@...gle.com, jgross@...e.com,
 andreyknvl@...il.com, scott@...amperecomputing.com, tony.luck@...el.com,
 dvyukov@...gle.com, pasha.tatashin@...een.com, ziy@...dia.com,
 broonie@...nel.org, gatlin.newhouse@...il.com, jackmanb@...gle.com,
 wangkefeng.wang@...wei.com, thiago.bauermann@...aro.org, tglx@...utronix.de,
 kees@...nel.org, akpm@...ux-foundation.org, jason.andryuk@....com,
 snovitoll@...il.com, xin@...or.com, jan.kiszka@...mens.com, bp@...en8.de,
 rppt@...nel.org, peterz@...radead.org, pankaj.gupta@....com,
 thuth@...hat.com, andriy.shevchenko@...ux.intel.com,
 joel.granados@...nel.org, kbingham@...nel.org, nicolas@...sle.eu,
 mark.rutland@....com, surenb@...gle.com, catalin.marinas@....com,
 morbo@...gle.com, justinstitt@...gle.com, ubizjak@...il.com,
 jhubbard@...dia.com, urezki@...il.com, dave.hansen@...ux.intel.com,
 bhe@...hat.com, luto@...nel.org, baohua@...nel.org, nathan@...nel.org,
 will@...nel.org, brgerst@...il.com, llvm@...ts.linux.dev,
 linux-mm@...ck.org, linux-doc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com, x86@...nel.org
Subject: Re: [PATCH v3 10/14] x86: Update the KASAN non-canonical hook

On 4/9/25 07:34, Maciej Wieczor-Retman wrote:
> Yes, I like it more than just generating the addresses in the parenthesis. What
> do you think about this naming? KASAN prefix and [k/u]addr since it's not really
> the lowest/highest address in the whole LA, just in this KASAN compiler scheme.
> And I changed 1<<56 to 2<<56 so it generates 0xFE00000000000000 instead of
> 0xFF00000000000000.
> 
> 	#define KASAN_HIGHEST_KADDR (void *)0xFFFFFFFFFFFFFFFF
> 	#define KASAN_LOWEST_KADDR (void *)(KASAN_HIGHEST_KADDR - \
> 						(2<<56) + 1)
> 	#define KASAN_HIGHEST_UADDR (void *)0x7FFFFFFFFFFFFFFF
> 	#define KASAN_LOWEST_UADDR (void *)(KASAN_HIGHEST_UADDR - \
> 						(2<<56) + 1)

Yes, that is much better.