linux-kernel - Re: commit 7b025f3f85ed causes NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409182917.GBZ_a8fYnLJHngPM0Z@fat_crate.local>
Date: Wed, 9 Apr 2025 20:29:17 +0200
From: Borislav Petkov <bp@...en8.de>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Bert Karwatzki <spasswolf@....de>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-kernel@...r.kernel.org, James.Bottomley@...senpartnership.com,
	Jonathan.Cameron@...wei.com, allenbh@...il.com, d-gole@...com,
	dave.jiang@...el.com, haiyangz@...rosoft.com, jdmason@...zu.us,
	kristo@...nel.org, linux-hyperv@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-scsi@...r.kernel.org,
	logang@...tatee.com, manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com, maz@...nel.org, mhklinux@...look.com,
	nm@...com, ntb@...ts.linux.dev, peterz@...radead.org,
	ssantosh@...nel.org, wei.huang2@....com, wei.liu@...nel.org
Subject: Re: commit 7b025f3f85ed causes NULL pointer dereference

On Tue, Apr 08, 2025 at 10:46:12PM +0200, Thomas Gleixner wrote:
> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> index 4027abcafe7a..77cc27e45b66 100644
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -680,8 +680,8 @@ static int __msix_setup_interrupts(struct pci_dev *__dev, struct msix_entry *ent
>  	if (ret)
>  		return ret;
>  
> -	retain_ptr(dev);
>  	msix_update_entries(dev, entries);
> +	retain_ptr(dev);
>  	return 0;

Tested-by: Borislav Petkov (AMD) <bp@...en8.de>

Fixes my machine too.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette