linux-kernel - Re: [PATCH RFC 4/6] dt-bindings: sram: qcom,imem: add the support for restart reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdf2d127-a4a6-4a4f-89ac-9f9dbe136ff8@kernel.org>
Date: Wed, 9 Apr 2025 09:02:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH RFC 4/6] dt-bindings: sram: qcom,imem: add the support for
 restart reason

On 08/04/2025 10:49, Kathiravan Thirumoorthy wrote:
> In the Qualcomm IPQ SoCs, system restart reason is captured in the IMEM
> location by bootloaders and Linux populates this information to the
> userspace. Add a child node for the restart reason in the IMEM region.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>
> ---
>  .../devicetree/bindings/sram/qcom,imem.yaml        | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index dec1b1ee924cf1386f559eb262ea864f2788c165..c3dab5fbc88c1515bfb3585f18aed9e01ae36fe4 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -56,6 +56,10 @@ patternProperties:
>      $ref: /schemas/remoteproc/qcom,pil-info.yaml#
>      description: Peripheral image loader relocation region
>  
> +  "^restart-reason@[0-9a-f]+$":
> +    $ref: /schemas/watchdog/qcom,restart-reason.yaml#

Just fold it here... but really, there is little point in describing
memory layout of syscon block register by register. What will be next?
Another entry for one more register? And then another? And another? And
every time you will claim "just this one", because you decide not to
provide complete picture when sending bindings for the first time?


Best regards,
Krzysztof