linux-kernel - Re: [PATCH 13/24] arm64/sysreg: Add ICH_HFGWTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a1c79f36-322f-4444-992b-1b69d8232124@app.fastmail.com>
Date: Wed, 09 Apr 2025 09:48:49 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Lorenzo Pieralisi" <lpieralisi@...nel.org>,
 "Marc Zyngier" <maz@...nel.org>, "Thomas Gleixner" <tglx@...utronix.de>,
 "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Catalin Marinas" <catalin.marinas@....com>, "Will Deacon" <will@...nel.org>
Cc: "Sascha Bischoff" <sascha.bischoff@....com>,
 "Timothy Hayes" <timothy.hayes@....com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 13/24] arm64/sysreg: Add ICH_HFGWTR_EL2

On Tue, Apr 8, 2025, at 12:50, Lorenzo Pieralisi wrote:
> Add ICH_HFGWTR_EL2 register description to sysreg.
>
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Will Deacon <will@...nel.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Marc Zyngier <maz@...nel.org>

No comment on the contents, but I feel that having ten patches
adding new sysregs one group at a time is a bit worse than a
single patch adding them all. The patch descriptions don't add
any particular information about why these are distinct, and you
need them all anyway, so I'd suggest combining them into a
larger patch.

      Arnd