linux-kernel - Re: [PATCH] drm/nouveau: Remove forgotten TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_ZTrZ-dcD5YiSm4@cassiopeiae>
Date: Wed, 9 Apr 2025 13:02:05 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Philipp Stanner <phasta@...nel.org>
Cc: Lyude Paul <lyude@...hat.com>, David Airlie <airlied@...il.com>,
	Ben Skeggs <bskeggs@...dia.com>, Simona Vetter <simona@...ll.ch>,
	lists.freedesktop.org@...siopeiae.smtp.subspace.kernel.org,
	nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau: Remove forgotten TODO

(+ Ben)

On Wed, Apr 09, 2025 at 11:14:14AM +0200, Philipp Stanner wrote:
> commit ebb945a94bba ("drm/nouveau: port all engines to new engine module
> format") introduced a TODO to nouveau_chan.h, stating that an
> unspecified rework would take place in the "near future".
> 
> Almost 13 years have passed since this "near future", so it can be
> safely assumed that the TODO is not needed anymore. Besides, its content
> is useless anyways since it does not specify *what* should have been
> done.
> 
> Remove the TODO.
> 
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> ---
>  drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h b/drivers/gpu/drm/nouveau/nouveau_chan.h
> index 016f668c0bc1..3b73ec91c4ff 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_chan.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_chan.h
> @@ -33,7 +33,6 @@ struct nouveau_channel {
>  		u64 addr;
>  	} push;
>  
> -	/* TODO: this will be reworked in the near future */
>  	bool accel_done;

After having a brief look, it seems that it may has actually been reworked;
there is only a single use of accel_done, which is in FIRE_RING(), where it is
set to true. But it doesn't seem to be read from anywhere.

So, I think we should remove both, the TODO and the accel_done field.

@Ben: Maybe you remember the history of this.

- Danilo