linux-kernel - Re: [PATCH] drm/nouveau: Remove forgotten TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481a2808c235f95726d17803503b2b6dc2746dc3.camel@mailbox.org>
Date: Thu, 31 Jul 2025 17:46:30 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Danilo Krummrich <dakr@...nel.org>, Philipp Stanner <phasta@...nel.org>
Cc: David Airlie <airlied@...il.com>, Ben Skeggs <bskeggs@...dia.com>, 
 Simona Vetter <simona@...ll.ch>, nouveau@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau: Remove forgotten TODO

On Wed, 2025-04-09 at 13:02 +0200, Danilo Krummrich wrote:
> (+ Ben)
> 
> On Wed, Apr 09, 2025 at 11:14:14AM +0200, Philipp Stanner wrote:
> > commit ebb945a94bba ("drm/nouveau: port all engines to new engine module
> > format") introduced a TODO to nouveau_chan.h, stating that an
> > unspecified rework would take place in the "near future".
> > 
> > Almost 13 years have passed since this "near future", so it can be
> > safely assumed that the TODO is not needed anymore. Besides, its content
> > is useless anyways since it does not specify *what* should have been
> > done.
> > 
> > Remove the TODO.
> > 
> > Signed-off-by: Philipp Stanner <phasta@...nel.org>
> > ---
> >  drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h b/drivers/gpu/drm/nouveau/nouveau_chan.h
> > index 016f668c0bc1..3b73ec91c4ff 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_chan.h
> > +++ b/drivers/gpu/drm/nouveau/nouveau_chan.h
> > @@ -33,7 +33,6 @@ struct nouveau_channel {
> >  		u64 addr;
> >  	} push;
> >  
> > -	/* TODO: this will be reworked in the near future */
> >  	bool accel_done;
> 
> After having a brief look, it seems that it may has actually been reworked;
> there is only a single use of accel_done, which is in FIRE_RING(), where it is
> set to true. But it doesn't seem to be read from anywhere.
> 
> So, I think we should remove both, the TODO and the accel_done field.
> 
> @Ben: Maybe you remember the history of this.

Since we didn't get an answer – how do we want to continue with that,
Danilo?


P.


> 
> - Danilo