linux-kernel - Re: [PATCH v2] RDMA/cma: Fix workqueue crash in cma_netevent_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174419763484.373763.12978802764991350026.b4-ty@kernel.org>
Date: Wed, 09 Apr 2025 07:20:34 -0400
From: Leon Romanovsky <leon@...nel.org>
To: jgg@...pe.ca, phaddad@...dia.com, markzhang@...dia.com, 
 Sharath Srinivasan <sharath.srinivasan@...cle.com>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, 
 stable@...r.kernel.org, haakon.bugge@...cle.com, aron.silverton@...cle.com
Subject: Re: [PATCH v2] RDMA/cma: Fix workqueue crash in
 cma_netevent_work_handler


On Wed, 26 Mar 2025 14:05:32 -0700, Sharath Srinivasan wrote:
> struct rdma_cm_id has member "struct work_struct net_work"
> that is reused for enqueuing cma_netevent_work_handler()s
> onto cma_wq.
> 
> Below crash[1] can occur if more than one call to
> cma_netevent_callback() occurs in quick succession,
> which further enqueues cma_netevent_work_handler()s for the
> same rdma_cm_id, overwriting any previously queued work-item(s)
> that was just scheduled to run i.e. there is no guarantee
> the queued work item may run between two successive calls
> to cma_netevent_callback() and the 2nd INIT_WORK would overwrite
> the 1st work item (for the same rdma_cm_id), despite grabbing
> id_table_lock during enqueue.
> 
> [...]

Applied, thanks!

[1/1] RDMA/cma: Fix workqueue crash in cma_netevent_work_handler
      https://git.kernel.org/rdma/rdma/c/052996ebc39e3e

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>