linux-kernel - Re: [PATCH] doc,cgroup-v2: memory.max is reported in multiples of page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <la6q2koug4ohzcfc5eqguod7x6fdwhndqkhzfrttsfnjo5fbb3@xzxodtpjl6ww>
Date: Thu, 10 Apr 2025 15:47:06 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Vishal Chourasia <vishalc@...ux.ibm.com>
Cc: tj@...nel.org, hannes@...xchg.org, corbet@....net, 
	cgroups@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc,cgroup-v2: memory.max is reported in multiples of
 page size

Hello.

On Thu, Apr 10, 2025 at 07:04:40PM +0530, Vishal Chourasia <vishalc@...ux.ibm.com> wrote:
> Update documentation for memory.max to clarify that the reported value
> is in multiples of the system page_size. The following example
> demonstrates this behavior:

This applies to any of page_counter-based attribute, not only
memory.max.

> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1316,6 +1316,9 @@ PAGE_SIZE multiple when read back.
>  	Caller could retry them differently, return into userspace
>  	as -ENOMEM or silently ignore in cases like disk readahead.
>  
> +        Note that the value set for memory.max is reported in units
> +        corresponding to the system's page size.
> +

There seems to be mismatch in whitespace to surrounding text.

Also the wording would be more precise if it referred to 'multiples',
not 'units' (units are simply bytes).

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)