linux-kernel - Re: [PATCH v14 2/3] soc: sophgo: cv1800: rtcsys: New driver (handling RTC only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aczljpyu56po7xkhqjjelatfw5l6bpqskvd3jnl4muy4pt3rjj@5q6imbmcqng2>
Date: Thu, 10 Apr 2025 13:44:38 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>, 
	sophgo@...ts.linux.dev, devicetree@...r.kernel.org, linux-rtc@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Inochi Amaoto <inochiama@...il.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Jingbao Qiu <qiujingbao.dlmu@...il.com>, 
	Arnd Bergmann <arnd@...db.de>, Yangyu Chen <cyy@...self.name>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 2/3] soc: sophgo: cv1800: rtcsys: New driver
 (handling RTC only)

On Sat, Mar 15, 2025 at 11:49:13PM +0100, Alexander Sverdlin wrote:
> Add driver for Sophgo CV1800 series SoC RTC subsystem. The RTC module
> comprises a 32kHz oscillator, Power-on-Reset (PoR) sub-module, HW state
> machine to control chip power-on, power-off and reset. Furthermore, the
> 8051 subsystem is located within RTCSYS including associated SRAM block.
> 
> This patch only populates RTC sub-device.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> ---
> Changelog:
> v14:
> - Dropped MAINTAINERS F: entry in favour of the existing N: entry
> - mfd_cell name "cv1800-rtc" -> "cv1800b-rtc"
> - Removed Cvitek brand from Kconfig
> - Not built by default if COMPILE_TEST
> v13:
> - Moved the driver from MFD into SOC subsystem
> - Dropped unused "cv1800_rtcsys_rtc_subdev"
> v12:
> - new patch
> 
>  drivers/soc/Kconfig                |  1 +
>  drivers/soc/Makefile               |  1 +
>  drivers/soc/sophgo/Kconfig         | 23 ++++++++++++
>  drivers/soc/sophgo/Makefile        |  3 ++
>  drivers/soc/sophgo/cv1800-rtcsys.c | 63 ++++++++++++++++++++++++++++++
>  6 files changed, 93 insertions(+)
>  create mode 100644 drivers/soc/sophgo/Kconfig
>  create mode 100644 drivers/soc/sophgo/Makefile
>  create mode 100644 drivers/soc/sophgo/cv1800-rtcsys.c
> 

LGTM.

Reviewed-by: Inochi Amaoto <inochiama@...il.com>