[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3m3amtjnqcrice2tfxw2ky7f65u574yi7crmcg7j7q3tnkk3zp@k7a5alzdbffb>
Date: Thu, 10 Apr 2025 13:45:00 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>,
sophgo@...ts.linux.dev, devicetree@...r.kernel.org, linux-rtc@...r.kernel.org
Cc: Jingbao Qiu <qiujingbao.dlmu@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Chen Wang <unicorn_wang@...look.com>, Inochi Amaoto <inochiama@...il.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>, Arnd Bergmann <arnd@...db.de>, Yangyu Chen <cyy@...self.name>,
linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v14 1/3] dt-bindings: soc: sophgo: add RTC support for
Sophgo CV1800 series
On Sat, Mar 15, 2025 at 11:49:12PM +0100, Alexander Sverdlin wrote:
> From: Jingbao Qiu <qiujingbao.dlmu@...il.com>
>
> Add RTC devicetree binding for Sophgo CV1800 series SoC. The device is
> called RTC, but contains control registers of other HW blocks in its
> address space, most notably of Power-on-Reset (PoR) module, DW8051 IP
> (MCU core), accompanying SRAM, hence putting it in SoC subsystem.
>
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> Changelog:
> v14:
> - no changes
> v13:
> - Moved bindings from MFD into SOC subsystem
>
> v12:
> - maintainer Jingbao Qiu <qiujingbao.dlmu@...il.com> -> sophgo@...ts.linux.dev
> - dropped Reviewed-by: Krzysztof Kozlowski
> - link to TRM
> - mentioned 8051 core in the description
> - binding is now MFD, not RTC
> - added "syscon" compatible
> - added "interrupt-names", "clock-names" (because of added PM/remoteproc)
> - main compatible "sophgo,cv1800-rtc" -> "sophgo,cv1800b-rtc"
>
> .../soc/sophgo/sophgo,cv1800b-rtc.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
LGTM.
Reviewed-by: Inochi Amaoto <inochiama@...il.com>
Powered by blists - more mailing lists