linux-kernel - Re: [PATCH v14 3/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB22628A1AF7C3B2DAAE837CE3FEB32@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 14 Apr 2025 17:14:28 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Jingbao Qiu <qiujingbao.dlmu@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Yangyu Chen <cyy@...self.name>, linux-kernel@...r.kernel.org,
 sophgo@...ts.linux.dev, devicetree@...r.kernel.org,
 linux-rtc@...r.kernel.org, Inochi Amaoto <inochiama@...il.com>
Subject: Re: [PATCH v14 3/3] rtc: sophgo: add rtc support for Sophgo CV1800
 SoC

Hi, Alexander Sverdlin,

I just find there is an exiting "REAL TIME CLOCK (RTC) SUBSYSTEM" 
section in MAINTAINERS, seems we should not pick the rtc file in "SOPHGO 
DEVICETREES and DRIVERS".

Chen

On 2025/3/19 8:31, Chen Wang wrote:
> Hi, Inochi,
>
> I see Alexander add "drivers/rtc/rtc-cv1800.c" in "SOPHGO DEVICETREES 
> and DRIVERS" of MAINTAINERS, would you like to take this?
>
> Regards,
>
> Chen
>
> On 2025/3/16 6:49, Alexander Sverdlin wrote:
>> From: Jingbao Qiu <qiujingbao.dlmu@...il.com>
>>
>> Implement the RTC driver for CV1800, which able to provide time alarm.
>>
>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
>> ---
>> Changelog:
>> v14:
>> - platform device name "cv1800-rtc" -> "cv1800b-rtc"
>> v13:
>> - Change in the Kconfig dependency caused by the move of the previous
>>    patch from MFD into SOC
>> v12:
>> - added MAINTAINERS entry
>> - depends on cv1800-rtcsys MFD driver
>> - use syscon for regmap
>> - get named clock from parent MFD
>> - corresponding platform device is expected to be instantiated by MFD 
>> stub
>> Changes since v10:
>> - only start RTC on set_time;
>> Changes since v9:
>> - further simplified bitmask macros;
>> - unconditional RTC start (rtc_enable_sec_counter()), otherwise
>> didn't start on SG2000;
>> - dropped ANA_CALIB modification (has been forgotten in v8 with
>> the drop of SW calibration to switch to HW calibration);
>> - successfully tested on SG2000;
>>
>>
>>   MAINTAINERS              |   1 +
>>   drivers/rtc/Kconfig      |  12 +++
>>   drivers/rtc/Makefile     |   1 +
>>   drivers/rtc/rtc-cv1800.c | 218 +++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 232 insertions(+)
>>   create mode 100644 drivers/rtc/rtc-cv1800.c
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ac15e448fffb..be8fee50a49c 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -22354,6 +22354,7 @@ L:    sophgo@...ts.linux.dev
>>   W:    https://github.com/sophgo/linux/wiki
>>   T:    git https://github.com/sophgo/linux.git
>>   S:    Maintained
>> +F:    drivers/rtc/rtc-cv1800.c
>>   N:    sophgo
>>   K:    sophgo
>
> [......]
>
>
>