linux-kernel - Re: [PATCH] misc: tps6594-pfsm: Add NULL check in tps6594_pfsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b1632d8b-d5c2-44dd-bec1-78aa0a71eb03@app.fastmail.com>
Date: Thu, 10 Apr 2025 12:56:06 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Charles Han" <hanchunchao@...pur.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Julien Panis" <jpanis@...libre.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: tps6594-pfsm: Add NULL check in tps6594_pfsm_probe

On Thu, Apr 10, 2025, at 12:52, Charles Han wrote:
> +	if (!pfsm->miscdev.name) {
> +		devm_kfree(dev, pfsm);
> +		return -ENOMEM;
> +	}

Since this is the probe function, you don't need to call devm_kfree()
but just let devres take care of it.

     Arnd