linux-kernel - Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6369e9e1-aa84-45d9-ad01-28594c280de4@microchip.com>
Date: Fri, 11 Apr 2025 14:06:35 +0000
From: <Valentina.FernandezAlanis@...rochip.com>
To: <yuehaibing@...wei.com>, <jassisinghbrar@...il.com>, <afd@...com>,
	<Valentina.FernandezAlanis@...rochip.com>
CC: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

On 11/04/2025 08:57, Yue Haibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
> 
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
>          struct sbiret ret;
>                        ^~~
>    CC      drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
>          ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
>                ^~~~~~~~~
> 
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
> 
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
Acked-by: Valentina Fernandez <valentina.fernandezalanis@...rochip.com>
> ---
>   drivers/mailbox/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
> 
>   config MCHP_SBI_IPC_MBOX
>          tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> -       depends on RISCV_SBI || COMPILE_TEST
> -       depends on ARCH_MICROCHIP
> +       depends on RISCV_SBI
> +       depends on ARCH_MICROCHIP || COMPILE_TEST
>          help
>            Mailbox implementation for Microchip devices with an
>            Inter-process communication (IPC) controller.
> --
> 2.34.1
>