linux-kernel - Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f37e647d-7b17-4440-9d1b-f44d0ebab352@huawei.com>
Date: Wed, 14 May 2025 12:01:57 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: <jassisinghbrar@...il.com>, <afd@...com>,
	<valentina.fernandezalanis@...rochip.com>
CC: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

ping..

On 2025/4/11 15:57, Yue Haibing wrote:
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
> 
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
> 	struct sbiret ret;
> 	              ^~~
>   CC      drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
> 	ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
> 	      ^~~~~~~~~
> 
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
> 
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  drivers/mailbox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
>  
>  config MCHP_SBI_IPC_MBOX
>  	tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> -	depends on RISCV_SBI || COMPILE_TEST
> -	depends on ARCH_MICROCHIP
> +	depends on RISCV_SBI
> +	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	help
>  	  Mailbox implementation for Microchip devices with an
>  	  Inter-process communication (IPC) controller.