linux-kernel - Re: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411165353.GN395307@horms.kernel.org>
Date: Fri, 11 Apr 2025 17:53:53 +0100
From: Simon Horman <horms@...nel.org>
To: Thangaraj Samynathan <thangaraj.s@...rochip.com>
Cc: netdev@...r.kernel.org, bryan.whitehead@...rochip.com,
	UNGLinuxDriver@...rochip.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix
 memory allocation failure

On Thu, Apr 10, 2025 at 09:40:34AM +0530, Thangaraj Samynathan wrote:
> The driver allocates ring elements using GFP_DMA flags. There is
> no dependency from LAN743x hardware on memory allocation should be
> in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC
> 
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@...rochip.com>
> ---
> v0
> -Initial Commit
> 
> v1
> -Modified GFP flags from GFP_KERNEL to GFP_ATOMIC
> -added fixes tag
> 
> v2
> -Resubmit net-next instead of net

Hi Thangaraj,

Thanks for the update. And sorry for not noticing this
in my earlier review. But I have some more feedback:

* I don't think it is correct to refer to this as fixing a failure
  in the subject.

* I do think the subject prefix can be shortened to 'net: lan743x: '



Perhaps something more like this?

	[PATCH net-next v3] net: lan743x: Allocate rings outside ZONE_DMA

And perhaps also mention in the commit message that this
is consistent with the other caller of lan743x_rx_init_ring_element().

Thanks!