linux-kernel - Re: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82abc54e1773c10b0d4f94d0d4ab3d12c753b931.camel@microchip.com>
Date: Tue, 15 Apr 2025 04:53:36 +0000
From: <Rengarajan.S@...rochip.com>
To: <horms@...nel.org>, <Thangaraj.S@...rochip.com>
CC: <Bryan.Whitehead@...rochip.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <linux-kernel@...r.kernel.org>, <pabeni@...hat.com>,
	<kuba@...nel.org>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory
 allocation failure

Hi Simon,
Thanks for the comments. Have addressed your comments in the next
revison.

Thanks,
Thangaraj Samynathan

On Fri, 2025-04-11 at 17:53 +0100, Simon Horman wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Thu, Apr 10, 2025 at 09:40:34AM +0530, Thangaraj Samynathan wrote:
> > The driver allocates ring elements using GFP_DMA flags. There is
> > no dependency from LAN743x hardware on memory allocation should be
> > in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC
> > 
> > Signed-off-by: Thangaraj Samynathan <thangaraj.s@...rochip.com>
> > ---
> > v0
> > -Initial Commit
> > 
> > v1
> > -Modified GFP flags from GFP_KERNEL to GFP_ATOMIC
> > -added fixes tag
> > 
> > v2
> > -Resubmit net-next instead of net
> 
> Hi Thangaraj,
> 
> Thanks for the update. And sorry for not noticing this
> in my earlier review. But I have some more feedback:
> 
> * I don't think it is correct to refer to this as fixing a failure
>   in the subject.
> 
> * I do think the subject prefix can be shortened to 'net: lan743x: '
> 
> 
> 
> Perhaps something more like this?
> 
>         [PATCH net-next v3] net: lan743x: Allocate rings outside
> ZONE_DMA
> 
> And perhaps also mention in the commit message that this
> is consistent with the other caller of
> lan743x_rx_init_ring_element().
> 
> Thanks!