linux-kernel - Re: [PATCH] mm: remove unused mmap tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ucksa6coiwco3wpmcjtfwezqjigzm2zwvdvkt2ryvefzojtqy@4lda47c236uz>
Date: Fri, 11 Apr 2025 13:17:26 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Eric Mueller <emueller@...estorage.com>, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: remove unused mmap tracepoints

* Caleb Sander Mateos <csander@...estorage.com> [250411 12:18]:
> The vma_mas_szero and vma_store tracepoints are unused since commit
> fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator").
> Remove them so they are no longer listed as available tracepoints.
> 

Thanks for doing this.

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> Reported-by: Eric Mueller <emueller@...estorage.com>
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> ---
>  include/trace/events/mmap.h | 52 -------------------------------------
>  1 file changed, 52 deletions(-)
> 
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index f8d61485de16..ee2843a5daef 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -41,62 +41,10 @@ TRACE_EVENT(vm_unmapped_area,
>  		__entry->total_vm, __entry->flags, __entry->length,
>  		__entry->low_limit, __entry->high_limit, __entry->align_mask,
>  		__entry->align_offset)
>  );
>  
> -TRACE_EVENT(vma_mas_szero,
> -	TP_PROTO(struct maple_tree *mt, unsigned long start,
> -		 unsigned long end),
> -
> -	TP_ARGS(mt, start, end),
> -
> -	TP_STRUCT__entry(
> -			__field(struct maple_tree *, mt)
> -			__field(unsigned long, start)
> -			__field(unsigned long, end)
> -	),
> -
> -	TP_fast_assign(
> -			__entry->mt		= mt;
> -			__entry->start		= start;
> -			__entry->end		= end;
> -	),
> -
> -	TP_printk("mt_mod %p, (NULL), SNULL, %lu, %lu,",
> -		  __entry->mt,
> -		  (unsigned long) __entry->start,
> -		  (unsigned long) __entry->end
> -	)
> -);
> -
> -TRACE_EVENT(vma_store,
> -	TP_PROTO(struct maple_tree *mt, struct vm_area_struct *vma),
> -
> -	TP_ARGS(mt, vma),
> -
> -	TP_STRUCT__entry(
> -			__field(struct maple_tree *, mt)
> -			__field(struct vm_area_struct *, vma)
> -			__field(unsigned long, vm_start)
> -			__field(unsigned long, vm_end)
> -	),
> -
> -	TP_fast_assign(
> -			__entry->mt		= mt;
> -			__entry->vma		= vma;
> -			__entry->vm_start	= vma->vm_start;
> -			__entry->vm_end		= vma->vm_end - 1;
> -	),
> -
> -	TP_printk("mt_mod %p, (%p), STORE, %lu, %lu,",
> -		  __entry->mt, __entry->vma,
> -		  (unsigned long) __entry->vm_start,
> -		  (unsigned long) __entry->vm_end
> -	)
> -);
> -
> -
>  TRACE_EVENT(exit_mmap,
>  	TP_PROTO(struct mm_struct *mm),
>  
>  	TP_ARGS(mm),
>  
> -- 
> 2.45.2
>