| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250411174820.GA3602673-robh@kernel.org>
Date: Fri, 11 Apr 2025 12:48:20 -0500
From: Rob Herring <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, matthias.bgg@...il.com,
y.oudjana@...tonmail.com, lukas.bulwahn@...hat.com,
u.kleine-koenig@...libre.com, geert+renesas@...der.be,
amergnat@...libre.com, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v1 1/3] dt-bindings: clock: mediatek: Describe MT6893
Clock Controllers
On Thu, Apr 10, 2025 at 04:41:08PM +0200, AngeloGioacchino Del Regno wrote:
> Add bindings to describe both the System Clock Controllers,
> providing PLLs and main clocks, and the functional clock
> controllers, providing peripheral clocks (i2c, multimedia, etc),
> as found in the MediaTek Dimensity 1200 (MT6893) SoC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> .../bindings/clock/mediatek,mt6893-clock.yaml | 56 +++
> .../clock/mediatek,mt6893-sys-clock.yaml | 68 +++
These just duplicate the same schema as the mt8365 bindings. Just add
compatibles there.
Or I'm open to other options. The only variation among all of these
seems to be whether or not they have 'syscon' compatible or
'#reset-cells'. And for mt8188 it seems we have that wrong (see below)
In general, it would be nice to see more clean-ups of the existing
Mediatek stuff before a new SoC. It makes me sad when I appear to be the
only one that cares.
For reference, here's the top warnings for Mediatek on arm64 (999 total,
182 unique (stripping the dtb name), 27 undocumented compatibles). This
information is available daily from my CI job
(https://gitlab.com/robherring/linux-dt/-/jobs).
Mediatek has the most warnings with 182.
arch/arm64/boot/dts/mediatek:999:182
29 syscon@...00000 (mediatek,mt8183-mfgcfg): 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): panel-pins-default: 'panel-reset' does not match any of the regexes: '^pins', 'pinctrl-[0-9]+'
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc1-pins-uhs:pins-cmd-dat:mediatek,pull-up-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc1-pins-uhs:pins-clk:mediatek,pull-down-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc1-pins-default:pins-cmd-dat:mediatek,pull-up-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc1-pins-default:pins-clk:mediatek,pull-down-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc0-pins-uhs:pins-ds:mediatek,pull-down-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc0-pins-uhs:pins-clk:mediatek,pull-down-adv: 10 is not one of [0, 1, 2, 3]
27 pinctrl@...05000 (mediatek,mt8183-pinctrl): mmc0-pins-default:pins-clk:mediatek,pull-down-adv: 10 is not one of [0, 1, 2, 3]
27 dsi@...14000 (mediatek,mt8183-dsi): ports: 'port@1' is a required property
27 dsi@...14000 (mediatek,mt8183-dsi): ports: 'port@0' is a required property
27 dsi@...14000 (mediatek,mt8183-dsi): Unevaluated properties are not allowed ('ports' was unexpected)
27 bt-sco (linux,bt-sco): '#sound-dai-cells' is a required property
22 pmic (mediatek,mt6359): regulators: 'compatible' is a required property
22 pmic (mediatek,mt6359): '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
17 pinctrl@...05000 (mediatek,mt8183-pinctrl): volume-button-pins: 'voldn-btn-odl', 'volup-btn-odl' do not match any of the regexes: '^pins', 'pinctrl-[0-9]+'
17 pinctrl@...05000 (mediatek,mt8183-pinctrl): trackpad-pins: 'trackpad-int' does not match any of the regexes: '^pins', 'pinctrl-[0-9]+'
17 pinctrl@...05000 (mediatek,mt8183-pinctrl): touchscreen-pins: 'touch-int-odl', 'touch-rst-l' do not match any of the regexes: '^pins', 'pinctrl-[0-9]+'
17 pinctrl@...05000 (mediatek,mt8183-pinctrl): pp3300-panel-pins: 'panel-3v3-enable' does not match any of the regexes: '^pins', 'pinctrl-[0-9]+'
12 sound (mediatek,mt8186-mt6366-rt1019-rt5682s-sound): 'model' is a required property
11 pinctrl@...05000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'gpio-line-names', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', 'pinctrl-[0-9]+'
11 mailbox@...30000 (mediatek,mt8188-gce): 'clock-names' is a required property
11 mailbox@...20000 (mediatek,mt8188-gce): 'clock-names' is a required property
11 clock-controller@...af000 (mediatek,mt8188-camsys-yuvb): '#reset-cells' is a required property
11 clock-controller@...8f000 (mediatek,mt8188-camsys-rawb): '#reset-cells' is a required property
11 clock-controller@...6f000 (mediatek,mt8188-camsys-yuva): '#reset-cells' is a required property
11 clock-controller@...4f000 (mediatek,mt8188-camsys-rawa): '#reset-cells' is a required property
11 clock-controller@...20000 (mediatek,mt8188-imgsys-wpe3): '#reset-cells' is a required property
11 clock-controller@...20000 (mediatek,mt8188-imgsys-wpe2): '#reset-cells' is a required property
11 clock-controller@...30000 (mediatek,mt8188-ipesys): '#reset-cells' is a required property
arch/arm64/boot/dts/mediatek:27
['dlg,da9211']
['marvell,sd8897-bt']
['mediatek,mt2712-pcie']
['mediatek,mt2712-scpsys', 'syscon']
['mediatek,mt6331-regulator']
['mediatek,mt6380-regulator']
['mediatek,mt6779-audio', 'syscon']
['mediatek,mt6795-timer', 'mediatek,mt6577-timer']
['mediatek,mt6797-scpsys']
['mediatek,mt7622-pcie']
['mediatek,mt7622-scpsys', 'syscon']
['mediatek,mt8173-afe-pcm']
['mediatek,mt8173-mdp-rdma', 'mediatek,mt8173-mdp']
['mediatek,mt8173-mdp-rdma']
['mediatek,mt8173-mdp-rsz']
['mediatek,mt8173-mdp-wdma']
['mediatek,mt8173-mdp-wrot']
['mediatek,mt8173-rt5650']
['mediatek,mt8173-vpu']
['mediatek,mt8183-audio']
['mediatek,mt8183-audiosys', 'syscon']
['mediatek,mt8183_da7219_max98357']
['mediatek,mt8183_da7219_rt1015p']
['mediatek,mt8183_mt6358_ts3a227_max98357']
['mediatek,mt8183_mt6358_ts3a227_rt1015p']
['melfas,mip4_ts']
['winbond,w25q64jwm', 'jedec,spi-nor']
Powered by blists - more mailing lists