linux-kernel - RE: [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03e501dbaab0$65bb47a0$3131d6e0$@samsung.com>
Date: Fri, 11 Apr 2025 12:37:19 +0530
From: "Faraz Ata" <faraz.ata@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, <alim.akhtar@...sung.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>
Cc: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<rosa.pila@...sung.com>, <dev.tailor@...sung.com>,
	<suyash.bitti@...sung.com>
Subject: RE: [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports

Hello Krzysztof

> Subject: Re: [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports
> 
> On 18/03/2025 08:56, Faraz Ata wrote:
> > +
> > +		usi_17: usi@...800c0 {
> 
> Messed order. Keep nodes sorted by unit address (see DTS coding style).
> 
>
Thanks for your review
Based on the DTS coding style, it is acceptable to group nodes
of the same type together, even if it breaks the unit address ordering.
https://docs.kernel.org/6.12/devicetree/bindings/dts-coding-style.html
Please let me know your opinion on this.
Do you mean I should move all the USI_ node after pwm node?

> > +			compatible = "samsung,exynosautov920-usi",
> > +				     "samsung,exynos850-usi";
> > +			reg = <0x10d800c0 0x20>;
> > +			samsung,sysreg = <&syscon_peric1 0x1040>;
> > +			samsung,mode = <USI_V2_UART>;
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +			ranges;
> > +			clocks = <&cmu_peric1
> CLK_MOUT_PERIC1_NOC_USER>,
> > +				 <&cmu_peric1
> CLK_DOUT_PERIC1_USI17_USI>;
> > +			clock-names = "pclk", "ipclk";
> > +			status = "disabled";
> > +
> > +			serial_17: serial@...80000 {
> > +				compatible = "samsung,exynosautov920-
> uart",
> > +					     "samsung,exynos850-uart";
> > +				reg = <0x10d80000 0xc0>;
> > +				interrupts = <GIC_SPI 803
> IRQ_TYPE_LEVEL_HIGH>;
> > +				pinctrl-names = "default";
> > +				pinctrl-0 = <&uart17_bus>;
> > +				clocks = <&cmu_peric1
> CLK_MOUT_PERIC1_NOC_USER>,
> > +					 <&cmu_peric1
> CLK_DOUT_PERIC1_USI17_USI>;
> > +				clock-names = "uart", "clk_uart_baud0";
> > +				samsung,uart-fifosize = <64>;
> > +				status = "disabled";
> > +			};
> > +		};
> > +
> >  		pwm: pwm@...b0000 {
> >  			compatible = "samsung,exynosautov920-pwm",
> >  				     "samsung,exynos4210-pwm";
> 
> 
> Best regards,
> Krzysztof